Refactor and fix cd #570
Merged
Refactor and fix cd #570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There have been a few releases where suddenly it became impossible to write multiple times to the same build artifact. This causes issues potentially. Did you confirm the output is correct now? |
Working on it ... |
|
I made a draft release, with the pypi code disabled, to test that it works. I have deleted the draft release. |
Korijn
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The release did not go through due to issues with cd. I fixed it (I think) by bumping the version numbers of actions. I also bumped for other actions, and refactored the cd into its own script.
set-output, because its deprecated